Ensure null inputs to array setop functions return null output #19683
+115
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Jan 7, 2026
Comment on lines
-371
to
+372
| let l_values = if let Some(first_arr) = first_arr { | ||
| converter.convert_columns(&[first_arr])? | ||
| } else { | ||
| ele_should_be_null = true; | ||
| converter.empty_rows(0, 0) | ||
| }; | ||
|
|
||
| let r_values = if let Some(second_arr) = second_arr { | ||
| converter.convert_columns(&[second_arr])? | ||
| } else { | ||
| ele_should_be_null = true; | ||
| converter.empty_rows(0, 0) | ||
| let (l_values, r_values) = match (l_arr, r_arr) { | ||
| (Some(l_arr), Some(r_arr)) => ( | ||
| converter.convert_columns(&[l_arr])?, | ||
| converter.convert_columns(&[r_arr])?, | ||
| ), | ||
| _ => { |
Contributor
Author
There was a problem hiding this comment.
Little drive-by refactor here to skip the set logic below for nulls
github-actions
bot
added
the
documentation
kosiew
approved these changes
Jan 14, 2026
| continue; | ||
| } | ||
|
|
||
| for i in r_start.as_usize()..r_end.as_usize() { |
Contributor
There was a problem hiding this comment.
Did you intentionally want to shadow i which is used in the outer for loop?
Contributor
Author
There was a problem hiding this comment.
This wasn't intentional, refactored the names to clear things up 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Explained in issue.
What changes are included in this PR?
Change array_except, array_intersect and array_union UDFs to return null if either input is null.
Are these changes tested?
Added & fixed tests.
Are there any user-facing changes?
Behaviour change to a function output.